Skip to content

Remove hardcoded version text from settings layout#43

Merged
ardevd merged 2 commits intoversion-info-in-settingsfrom
copilot/sub-pr-42
Feb 8, 2026
Merged

Remove hardcoded version text from settings layout#43
ardevd merged 2 commits intoversion-info-in-settingsfrom
copilot/sub-pr-42

Conversation

Copy link

Copilot AI commented Feb 8, 2026

Addresses feedback from #42 regarding hardcoded android:text="v1.0.0" in the settings layout XML, which would be incorrect for non-1.0.0 builds and can trigger lint warnings.

Changes:

  • Removed android:text="v1.0.0" from versionText TextView
  • Added tools:text="v1.0.0" for layout preview
  • Added xmlns:tools namespace declaration

The version is set programmatically via BuildConfig.VERSION_NAME in SettingsBottomSheet.kt:

binding.versionText.text = "v$version"

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: ardevd <366855+ardevd@users.noreply.github.com>
@ardevd ardevd marked this pull request as ready for review February 8, 2026 20:39
@ardevd ardevd merged commit bfb5aab into version-info-in-settings Feb 8, 2026
@ardevd ardevd deleted the copilot/sub-pr-42 branch February 8, 2026 20:40
Copilot AI restored the copilot/sub-pr-42 branch February 8, 2026 20:40
Copy link
Author

Copilot AI commented Feb 8, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on version info in settings sheet Remove hardcoded version text from settings layout Feb 8, 2026
Copilot stopped work on behalf of ardevd due to an error February 8, 2026 20:40
Copilot AI requested a review from ardevd February 8, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants